[MIRROR] Fix some shenanigans involving interaction order with wound tending #1067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tending [MDB IGNORE] (#25551) * Fix some shenanigans involving interaction order with wound tending (#80225) ## About The Pull Request Fixes #80223 . See issue for information about the bug. This PR fixes it by placing wound tending before parent call but after surgery. It also fixes it by rewriting a little bit of medical stack item code to only block interaction chain when actually healing someone - This is not necessary with the above fix, but it futureproofs things. ## Changelog :cl: Melbert fix: When using an item on a mob, you will always attempt to fix wounds AFTER surgery, BUT BEFORE the item's own interactions. As an example, this means using a mesh on a mob will attempt to progress surgery first, then attempt to fix any burn wounds, then heal burn damage. /:cl: * Fix some shenanigans involving interaction order with wound tending --------- Co-authored-by: MrMelbert <[email protected]>
AnywayFarus
added a commit
that referenced
this pull request
Dec 12, 2023
Iajret
pushed a commit
that referenced
this pull request
Feb 24, 2024
…or players to make thatch floors + Bonus fixes to primitive storage structures (#1067) * Adds thatch as a result of drying grass, usable to make thatch patches * Fixes a few bugs with what drops from primitive storage structures + decapitalizes their names * weapon -> item_to_check * Addresses more review comments * Fixes it being able to move things you shouldn't be able to move with shelves
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Skyrat: Skyrat-SS13/Skyrat-tg#25551
Original PR: tgstation/tgstation#80225
About The Pull Request
Fixes #80223 . See issue for information about the bug.
This PR fixes it by placing wound tending before parent call but after surgery.
It also fixes it by rewriting a little bit of medical stack item code to only block interaction chain when actually healing someone - This is not necessary with the above fix, but it futureproofs things.
Changelog
🆑 Melbert
fix: When using an item on a mob, you will always attempt to fix wounds AFTER surgery, BUT BEFORE the item's own interactions. As an example, this means using a mesh on a mob will attempt to progress surgery first, then attempt to fix any burn wounds, then heal burn damage.
/:cl: